Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pybinds for saving and loading geometry from a .scene file #2971

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add pybinds for saving and loading geometry from a .scene file #2971

merged 3 commits into from
Aug 15, 2024

Conversation

bgill92
Copy link
Contributor

@bgill92 bgill92 commented Aug 13, 2024

Description

This PR adds pybinds for loading geometry from a .scene file using the loadGeometryfromStream and saveGeometrytoStream functionality.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

rhaschke
rhaschke reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Please consider my comments.

moveit_py/src/moveit/moveit_core/planning_scene/planning_scene.cpp Outdated Show resolved Hide resolved
moveit_py/src/moveit/moveit_core/planning_scene/planning_scene.cpp Outdated Show resolved Hide resolved
moveit_py/src/moveit/moveit_core/planning_scene/planning_scene.h Outdated Show resolved Hide resolved
moveit_py/moveit/core/planning_scene.pyi Outdated Show resolved Hide resolved
@bgill92 bgill92 requested a review from rhaschke August 14, 2024 18:27
@bgill92 bgill92 self-assigned this Aug 14, 2024
@sjahr sjahr merged commit 208f7f7 into moveit:main Aug 15, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

Assignees

@bgill92 bgill92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgill92 @rhaschke @sjahr