Update the "format" workflow version of ubuntu #2966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sea-bass
approved these changes
Aug 12, 2024
rhaschke
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Having Ubuntu 22.04 here is for a reason: while most other workflows run a docker container and thus can run on any Ubuntu distro, this one directly runs in the given Ubuntu distro.
Using ubuntu-latest here will break the workflow in future, when latest refers to a future distro, which doesn't ship clang-format-14 anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you search the
.githubfolder, you'll see thatubuntu-latestis used almost everywhere. And that makes good sense. Switchubuntu-22.04toubuntu-latestin this one last place.