Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly load smoothing plugins in Servo integration tests #2965

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Aug 12, 2024

Description

I just realized in analyzing servo integration tests that they were pulling from the panda_simulated_config.yaml (which currently uses the Acceleration filter plugin), but still had the old parameters from the Butterworth filter plugin in the launch files.

As a consequence, the smoothing plugin was not loading correctly in these tests; see, e.g., this CI run.

This happens specifically because the Acceleration filter parameters do not have defaults, so they are required. Butterworth, on the other hand, has a default parameter value for its one coefficient.

@AndyZe FYI if you are switching the default in panda_simulated_config.yaml to the new Ruckig plugin in your PR, you will need to make similar updates in the integration test launch files as well.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass requested review from AndyZe, pac48 and sjahr August 12, 2024 01:03
@AndyZe AndyZe added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 3cb5f09 Aug 12, 2024
10 of 13 checks passed
@AndyZe AndyZe deleted the fix-smoothing-in-servo-integ-tests branch August 12, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants