Correctly load smoothing plugins in Servo integration tests #2965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I just realized in analyzing servo integration tests that they were pulling from the
panda_simulated_config.yaml
(which currently uses the Acceleration filter plugin), but still had the old parameters from the Butterworth filter plugin in the launch files.As a consequence, the smoothing plugin was not loading correctly in these tests; see, e.g., this CI run.
This happens specifically because the Acceleration filter parameters do not have defaults, so they are required. Butterworth, on the other hand, has a default parameter value for its one coefficient.
@AndyZe FYI if you are switching the default in
panda_simulated_config.yaml
to the new Ruckig plugin in your PR, you will need to make similar updates in the integration test launch files as well.Checklist