Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced gazebo_ros_control by gazebo_ros2_control #2886

Closed
wants to merge 2 commits into from

Conversation

vonunwerth
Copy link

Description

When using the tags generated in the package.xml for the use of Gazebo Classic, rosdep failed because it could not find the package gazebo_ros_control.

ERROR: the following packages/stacks could not have their rosdep keys resolved to system dependencies: ...: Cannot locate rosdep definition for [gazebo_ros_control]

I changed the template for the package.xml to include gazebo_ros2_control

It could also be useful to include a second commented paragraph containing gz_ros2_control for Gazebo.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

vonunwerth and others added 2 commits June 26, 2024 10:20
When using the <exec-depend> tags generated in the package.xml for the use of Gazebo, rosdep failed because it could not find the package gazebo_ros_control.
Copy link

@scastro-bdai scastro-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gazebo classic is no longer supported in Jazzy and onwards... so if anything, this should be gz_ros2_control. But we'd need to know if Gazebo Sim even works with these tools...

@sjahr
Copy link
Contributor

sjahr commented Jul 26, 2024

@vonunwerth Thanks for that PR, I'll close this for now because of Sebastian's comment + moveit2 shouldn't depend on it anyways

@sjahr sjahr closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants