Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to system version of octomap. #2881

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

clalancette
Copy link
Contributor

Description

This is so that we have a consistent ABI between these packages and anything else in the system that depends on octomap. We'll eventually be removing the ROS-provided version of octomap to make sure we don't have these problems in the future.

This should solve the issue in ros/rosdistro#41622 , and was enabled by the merging of ros/rosdistro#41623

Checklist

  • [N/A] Required by CI: Code is auto formatted using clang-format
  • [N/A] Extend the tutorials / documentation reference
  • [N/A] Document API changes relevant to the user in the MIGRATION.md notes
  • [N/A] Create tests, which fail without this PR reference
  • [N/A] Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is so that we have a consistent ABI between these
packages and anything else in the system that depends
on octomap.  We'll eventually be removing the ROS-provided
version of octomap to make sure we don't have these problems
in the future.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

Friendly ping on this one; we are going to shortly remove octomap from Rolling, and that will cause this package to fail to build without this patch.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjahr sjahr merged commit 42c5a29 into moveit:main Jul 8, 2024
9 of 11 checks passed
@clalancette clalancette deleted the clalancette/switch-to-system-octomap branch July 8, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants