-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with MoveIt1 #2504
base: main
Are you sure you want to change the base?
Sync with MoveIt1 #2504
Conversation
... as revealed by asan. Seems to be a bug in libyamlcpp.
- Directly use SRDFWriter as data source for data models - LinkPairMap only used temporarily in generateCollisionTable() - Use wip_srdf_ as work-in-progress copy of config_data_->srdf_ to allow reverting
Move common code into method selectedSections()
When switching from matrix to linear view, the checkbox state was ignored.
- Run costly mapToSource() only if actually needed - Signal dataChanged() on success only
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
==========================================
+ Coverage 50.40% 50.71% +0.31%
==========================================
Files 391 391
Lines 31982 32210 +228
==========================================
+ Hits 16117 16331 +214
- Misses 15865 15879 +14 ☔ View full report in Codecov by Sentry. |
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This pull request is in conflict. Could you fix it @Abishalini? |
This is a continued effort from #2212. I am breaking down the original author's PR into multiple PR so it is easy to review.
Syncing the following commits
The commits are from PR - moveit/moveit#3093
TODO