Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-format-14 with QualifierAlignment #2362

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

Shobuj-Paul
Copy link
Contributor

@Shobuj-Paul Shobuj-Paul commented Sep 14, 2023

Description

Adds Qualifier allignment to clang format in the following order: 'static', 'inline', 'constexpr', 'const', 'volatile', 'type'.
Fixes #1431

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 83.34% and project coverage change: +0.01% 🎉

Comparison is base (459b810) 50.74% compared to head (2597baf) 50.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
+ Coverage   50.74%   50.74%   +0.01%     
==========================================
  Files         386      386              
  Lines       31970    31970              
==========================================
+ Hits        16219    16220       +1     
+ Misses      15751    15750       -1     
Files Changed Coverage Δ
...tance_field/src/collision_distance_field_types.cpp 35.65% <ø> (ø)
...e/include/moveit/kinematics_base/kinematics_base.h 76.32% <ø> (ø)
...include/moveit/robot_trajectory/robot_trajectory.h 98.67% <ø> (ø)
..._interface/src/detail/constrained_goal_sampler.cpp 66.11% <ø> (ø)
...ial_motion_planner_testutils/xml_testdata_loader.h 85.72% <ø> (ø)
...g/rdf_loader/src/synchronized_string_parameter.cpp 32.31% <0.00%> (ø)
...ics_plugin_loader/src/kinematics_plugin_loader.cpp 78.69% <50.00%> (ø)
..._core/collision_detection/src/collision_matrix.cpp 37.15% <100.00%> (ø)
...eit_core/robot_trajectory/src/robot_trajectory.cpp 66.48% <100.00%> (ø)
...rajectory_processing/src/ruckig_traj_smoothing.cpp 65.75% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shobuj-Paul Shobuj-Paul marked this pull request as ready for review September 14, 2023 15:05
@Shobuj-Paul Shobuj-Paul force-pushed the clang_format_qualifiers branch from 0381cb4 to 2597baf Compare September 16, 2023 05:30
@tylerjw tylerjw merged commit 94fea79 into moveit:main Sep 21, 2023
8 checks passed
@Shobuj-Paul Shobuj-Paul deleted the clang_format_qualifiers branch September 21, 2023 13:33
m-elwin pushed a commit to m-elwin/moveit2 that referenced this pull request Dec 4, 2023
* Set qualifier order in .clang-format

* Ran pre-commit to update according to new style guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use clang-format's QualifierAlignment upon upgrade to clang-format-14
4 participants