CLOUDP-325047: add support for Extentensios to the Spec Struct
#774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
changed the title
Extentensios to the Spec Struct
Comment on lines
+132
to
+134
| for k, v := range doc.Extensions { | ||
| m[k] = v | ||
| } |
There was a problem hiding this comment.
this is the reason why we need this custom marshal
gssbzn
approved these changes
Jun 16, 2025
jeroenvervaeke
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is a follow up of #773 where I forgot to add a custom serielization to support the extension field.
Test
I generated the versioned spec using the mms spec in mms/master and checked that the extensions field was present.