CLOUDP-325047: add support for extension in the main element of the OAS #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
approved these changes
Jun 16, 2025
| @@ -34,6 +34,7 @@ type Spec struct { | |||
| Paths *openapi3.Paths `json:"paths" yaml:"paths"` | |||
| Components *openapi3.Components `json:"components,omitempty" yaml:"components,omitempty"` | |||
| ExternalDocs *openapi3.ExternalDocs `json:"externalDocs,omitempty" yaml:"externalDocs,omitempty"` | |||
| Extensions map[string]any `json:"-" yaml:"-"` | |||
There was a problem hiding this comment.
doesn't - means ignored? do you really mean to ignore this field?
There was a problem hiding this comment.
yes, I don't want to have the field name extensions in the serializated output. I am reusing the same definition in openapi3.go. It should work since we use the same definition also for Extensions fields in other structs. Btw, I will open a follow up PR to fix this if I am wrong.
There was a problem hiding this comment.
you are right, this does not work. I am adding the missing part here #774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
CLOUDP-325047:
Related to https://github.com/10gen/mms/pull/131979, bump recently added support for a custom extension. Here I am adding the support for extensions to the struct we use to represent an open api spec.