Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Bug fix: Synonym sync exclusions - mini build #748

Closed
wants to merge 2 commits into from

Conversation

joeflack4
Copy link
Contributor

- The exclusions were only excluding on matching scope. Now, they will exclude any instance of a synonym for a given mondo_id, regardless of scope, so long as they are in the exclusion config.
@joeflack4 joeflack4 requested a review from twhetzel January 12, 2025 02:52
@joeflack4 joeflack4 self-assigned this Jan 12, 2025
@joeflack4 joeflack4 added the bug Something isn't working label Jan 12, 2025
@joeflack4 joeflack4 mentioned this pull request Jan 12, 2025
9 tasks
@joeflack4
Copy link
Contributor Author

I intend mainly to do a repeat of monarch-initiative/mondo#8463 using this branch, rather than examining these files manually, and see if the QC error for qc-related-exact-synonym.sparql now goes away.

@joeflack4 joeflack4 marked this pull request as draft January 19, 2025 22:09
Base automatically changed from bugfix-syn-sync-exclusions to develop January 21, 2025 23:18
@joeflack4 joeflack4 closed this Jan 21, 2025
@joeflack4 joeflack4 deleted the bugfix-syn-sync-exclusions--mini-build branch January 21, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant