Skip to content

Form Customization: Reveal Content Above & Below Regions #16789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smg6511 wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Form Customization: Reveal Content Above & Below Regions #16789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1391e64
Reveal additional FC content regions
smg6511 Nov 30, 2025
f00441d
Update modx.panel.resource.js
smg6511 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/model/schema/modx.action.fields.schema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
<tab name="modx-resource-content">
<field name="modx-resource-content" />
</tab>
<tab name="modx-resource-content-above" />
<tab name="modx-resource-content-below" />
<tab name="modx-resource-main-right">
</tab>
<tab name="modx-resource-main-right-top">
Expand Down
15 changes: 13 additions & 2 deletions core/src/Revolution/modActionDom.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,21 @@ public function apply($objId = '')
$ruleType = $this->get('rule');

$container = json_encode($this->get('container'));
$itemId = json_encode($this->get('name'));
$itemId = $this->get('name');
$value = $this->get('value');

/** Backward compat: Support for legacy tab ids for above/below content regions */
foreach (['itemId', 'value'] as $identifier) {
$$identifier = in_array($$identifier, ['modx-content-above', 'modx-content-below'])
? str_replace('modx-', 'modx-resource-', $$identifier)
: $$identifier
;
}

$itemId = json_encode($itemId);
$value = in_array($ruleType, $boolRules)
? (int)$this->get('value')
: json_encode(htmlspecialchars($this->get('value'), ENT_COMPAT, $encoding))
: json_encode(htmlspecialchars($value, ENT_COMPAT, $encoding))
;

switch ($ruleType) {
Expand Down
8 changes: 6 additions & 2 deletions manager/assets/modext/widgets/resource/modx.panel.resource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,8 +1045,10 @@ Ext.extend(MODx.panel.Resource,MODx.FormPanel,{
,autoHeight: true
,hideMode: 'offsets'
,items: [{
id: 'modx-resource-content-above'
Copy link
Member

@theboxer theboxer Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, I'm not sure if big enough, but can break some extras that are injecting to those places and using the ID for identifying the space. (same goes for the modx-content-below)

Copy link
Collaborator Author

@smg6511 smg6511 Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be: There's BC support added in modActionDom that transforms the old id to the new one as the rules are actually being built. Is there a scenario I'm not thinking of that would be problematic?

Although I suppose I'm thinking of this specifically in the context of Form Customization; guessing you're thinking one might have reason to directly access these two components outside of the FC process?

Copy link
Collaborator Author

@smg6511 smg6511 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theboxer - Ok, to cover your concern I went ahead and added back in two items using the original ids with a deprecation notice.

},{
/** @deprecated To be removed in 3.3, reference new region id 'modx-resource-content-above' */
id: 'modx-content-above'
,border: false
},{
xtype: 'textarea'
,name: 'ta'
Expand All @@ -1057,8 +1059,10 @@ Ext.extend(MODx.panel.Resource,MODx.FormPanel,{
,grow: false
,value: (config.record.content || config.record.ta) || ''
},{
/** @deprecated To be removed in 3.3, reference new region id 'modx-resource-content-below' */
id: 'modx-content-below'
,border: false
},{
id: 'modx-resource-content-below'
}]
};
}
Expand Down
Loading