Form Customization: Reveal Content Above & Below Regions

[smg6511]

What does it do?

Adds missing regions to FC set schema and renames those regions’ IDs to be more consistent with current naming convention.

Why is it needed?

It's unclear that two additional regions exist above and below the main content field. Also, even though you can currently assign TVs to these regions, you can not control the overall visibility of those regions.

How to test

1. Because there's a change to a schema, a full rebuild (_build/transport.core.php) and running of the setup (install) must first be done
2. Create at least one TV for testing
3. Create a Form Customization set, and note that the modx-resource-content-above and modx-resource-content-below now show in the Regions tab
4. Move a TV to both of these regions and verify they appear in the expected position in a Resource
5. Uncheck each of these regions in the FC Set Region tab and verify each region is hidden when viewing a Resource
6. Also, verify that usage of the legacy Region IDs work as well (modx-content-above and modx-content-below)

Related issue(s)/PR(s)

Resolves #16442

[theboxer]

This is a breaking change, I'm not sure if big enough, but can break some extras that are injecting to those places and using the ID for identifying the space. (same goes for the modx-content-below)

[smg6511]

It shouldn't be: There's BC support added in modActionDom that transforms the old id to the new one as the rules are actually being built. Is there a scenario I'm not thinking of that would be problematic?

Although I suppose I'm thinking of this specifically in the context of Form Customization; guessing you're thinking one might have reason to directly access these two components outside of the FC process?

[smg6511]

@theboxer - Ok, to cover your concern I went ahead and added back in two items using the original ids with a deprecation notice.