Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gracefully support a lack of resolver settings #8

Closed
wants to merge 1 commit into from
Closed

gracefully support a lack of resolver settings #8

wants to merge 1 commit into from

Conversation

zepumph
Copy link

@zepumph zepumph commented Aug 31, 2021

This is to support PhET simulation integration of the default-import-match-filename rule. See #7

@minseoksuh
Copy link
Owner

minseoksuh commented Sep 1, 2021

@zepumph
Hi!

First of all, thank you so much for taking your time to looking into the issue and actually making a PR.

I have to let you know that common/resolve.js is a file I copied from eslint-plugin-import to make the rule default-import-match-filename work.

And it seems there already have been plenty reports on this issue.
What I found possibly promising were

import-js/eslint-plugin-import#828
airbnb/javascript#1730
https://stackoverflow.com/questions/44865507/eslint-no-duplicates-resolve-error-unable-to-load-resolver-node

Googling error code Resolve error: unable to load resolver "node" might give you more insights.

I believe trying out some of the suggested solutions will be more stable than fixing the code itself.

Let me know if you can find any workaround.

https://phet.colorado.edu/en/about

What a great great project btw.
I began coding about 2 - 3 years ago, and now I want to learn more about math and science nearly 5 years after college.
I think I can learn a lot from it.
Thanks for the great work!


if (!resolved.found) continue;
for (const pair of resolvers) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you deleted the resolvers variable and it was undefined when I checked.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for keeping me honest.

@zepumph
Copy link
Author

zepumph commented Sep 1, 2021

That makes a lot of sense to me. Thanks for showing me some of that research. I appreciate it. I'll go ahead and close this and the issue.

@zepumph zepumph closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants