You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello! I work for PhET Interactive simulations and we use eslint for code quality. I found this repo over in import-js/eslint-plugin-import#325 (comment), as we have the same goals for import filename validation. Specifics about our context are tracked over in phetsims/chipper#1079.
We want to use the rule: default-import-match-filename, but were finding this error in any file that had a failure for this rule:
1:1 error Resolve error: unable to load resolver "node" consistent-default-export-name/default-import-match-filename
In general the rule was working great, I just want to silence this error.
I poked through the common code, and found the error boils down to an assumption about common settings coming form the context.
I plan to submit a pull request for a fix that works for our project. Let me know what you think!
Best,
Michael
P.S. pardon the horrible name for this issue, I did the best I could to understand the context of the code I fixed, but really I was just trying to gracefully support our case for the rule.
The text was updated successfully, but these errors were encountered:
Hello! I work for PhET Interactive simulations and we use eslint for code quality. I found this repo over in import-js/eslint-plugin-import#325 (comment), as we have the same goals for import filename validation. Specifics about our context are tracked over in phetsims/chipper#1079.
We want to use the rule:
default-import-match-filename
, but were finding this error in any file that had a failure for this rule:In general the rule was working great, I just want to silence this error.
I poked through the common code, and found the error boils down to an assumption about common settings coming form the context.
https://github.com/minseoksuh/eslint-plugin-consistent-default-export-name/blob/main/lib/common/resolve.js#L144-L146
I plan to submit a pull request for a fix that works for our project. Let me know what you think!
Best,
Michael
P.S. pardon the horrible name for this issue, I did the best I could to understand the context of the code I fixed, but really I was just trying to gracefully support our case for the rule.
The text was updated successfully, but these errors were encountered: