-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add injection of custom executor service to S3Base supplyAsync calls #1543
base: master
Are you sure you want to change the base?
Conversation
Any custom requirements should be done by inheriting S3Base and override whatever methods you want. I am not sure why we need to take this into minio-java. |
74b14cf
to
a491d99
Compare
We are in an environment where we can't use the regular But in this situation allowing users to optionally supply their own Though we understand that this is an uncommon requirement, it would still be a great help to us if we can provide our own and I imagine there might be some other niche use cases that would benefit. Let me know what you think! |
5e2cfa9
to
30e9688
Compare
We have a use case where we need to provide our own thread pool for the
CompletableFuture.supplyAsync
to run on, currently that's not possible and it's preventing us from keeping up with library upgrades.