Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] make upload parts concurrent #1569

Closed
chenshi5012 opened this issue Jun 18, 2024 · 4 comments
Closed

[idea] make upload parts concurrent #1569

chenshi5012 opened this issue Jun 18, 2024 · 4 comments

Comments

@chenshi5012
Copy link

https://github.com/minio/minio-java/blob/f80a7021d87267fbab5bbbe3ef81064fae474082/api/src/main/java/io/minio/S3Base.java#L2839C12-L2839C85

Part[] parts = uploadParts(args, uploadId, partReader, firstPartSource);

suggest to make this upload parts concurrent .

@balamurugana
Copy link
Member

As the input stream is sequential and parallel uploads would result in huge memory usage. It is not a good idea.

@chenshi5012
Copy link
Author

As the input stream is sequential and parallel uploads would result in huge memory usage. It is not a good idea.
notice same idea. this pr #1543, try to use ForkJoinPool to make upload parallel. with diffrent objects 。

this can be apply to RandomAceessFile too. pls consider again.

@balamurugana
Copy link
Member

If you want to upload parts in parallel with different part sources, use UploadPartAsync and manage multipart uploads your own. For single input stream with lesser memory usage, this is not possible.

@chenshi5012
Copy link
Author

If you want to upload parts in parallel with different part sources, use UploadPartAsync and manage multipart uploads your own. For single input stream with lesser memory usage, this is not possible.

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants