fix: ChannelManager concurret Release and Watch bug #38590
Conversation
mergify
bot
added
dco-passed
|
@XuanYang-cn E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38590 +/- ##
===========================================
- Coverage 81.00% 69.33% -11.67%
===========================================
Files 1379 292 -1087
Lines 194495 26187 -168308
===========================================
- Hits 157546 18158 -139388
+ Misses 31393 8029 -23364
+ Partials 5556 0 -5556
|
See also: milvus-io#38589 Signed-off-by: yangxuan <[email protected]>
XuanYang-cn
force-pushed
the
fix-concurrent-issue
branch
from
327d2c6 to
fe7bfa8
Compare
|
@XuanYang-cn go-sdk check failed, comment |
|
rerun go-sdk |
See also: #38589 pr: #38590 Signed-off-by: yangxuan <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -191,7 +191,15 @@ func NewStateChannelByWatchInfo(nodeID int64, info *datapb.ChannelWatchInfo) *St | |||
| return c | |||
| } | |||
|
|
|||
| func (c *StateChannel) TransitionOnSuccess() { | |||
| func (c *StateChannel) TransitionOnSuccess(opID int64) { | |||
| if opID != c.Info.GetOpID() { | |||
There was a problem hiding this comment.
Approve for now. But we definitely need refactor here. We need to
- Return the Channel status on DN (Watching/Wachted/Releasing/Released/...)
- Group all info for a given channel on DC to determine the next step
See also: #38589