Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: State trans error in concurrent Release and Watching #38591

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #38589
pr: #38590

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 83.01887% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (451deb3) to head (8db49a5).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/channel.go 55.55% 7 Missing and 1 partial ⚠️
internal/datacoord/channel_store.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38591      +/-   ##
==========================================
+ Coverage   72.14%   72.16%   +0.02%     
==========================================
  Files        1077     1077              
  Lines      169415   169442      +27     
==========================================
+ Hits       122217   122278      +61     
+ Misses      42719    42699      -20     
+ Partials     4479     4465      -14     
Files with missing lines Coverage Δ
internal/datacoord/channel_manager_v2.go 87.14% <100.00%> (+0.27%) ⬆️
internal/datacoord/channel_store_v2.go 80.00% <100.00%> (ø)
internal/datacoord/channel_store.go 76.43% <0.00%> (ø)
internal/datacoord/channel.go 74.69% <55.55%> (-2.71%) ⬇️

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 19, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e82af48 into milvus-io:2.4 Dec 19, 2024
14 of 15 checks passed
@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 20, 2024
@XuanYang-cn XuanYang-cn deleted the cp24/fix-concurrent-issue branch December 20, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants