Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kafka use shared channel to receive produce result #38532

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 17, 2024

issue: #38531

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (e19a4f7) to head (fdc3132).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38532      +/-   ##
==========================================
- Coverage   82.80%   78.84%   -3.97%     
==========================================
  Files        1086     1370     +284     
  Lines      167965   192948   +24983     
==========================================
+ Hits       139088   152126   +13038     
- Misses      23336    35290   +11954     
+ Partials     5541     5532       -9     
Components Coverage Δ
Client 74.52% <ø> (ø)
Core 69.34% <ø> (∅)
Go 80.48% <100.00%> (-2.57%) ⬇️

see 550 files with indirect coverage changes

@czs007 czs007 added this to the 2.5.0 milestone Dec 17, 2024
Signed-off-by: chyezh <[email protected]>
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 17, 2024
@sre-ci-robot sre-ci-robot merged commit b18a3cf into milvus-io:master Dec 17, 2024
18 of 20 checks passed
@chyezh chyezh deleted the fix_kafka_break_wal_sematics branch December 18, 2024 01:56
sre-ci-robot pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants