Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kafka use shared channel to receive produce result #38534

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 17, 2024

issue: #38531
pr: #38532

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (6f573f6) to head (03ad51d).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38534      +/-   ##
==========================================
+ Coverage   72.15%   79.48%   +7.33%     
==========================================
  Files        1077     1077              
  Lines      169342   169342              
==========================================
+ Hits       122185   134603   +12418     
+ Misses      42685    30273   -12412     
+ Partials     4472     4466       -6     

see 247 files with indirect coverage changes

@czs007 czs007 added this to the 2.4.18 milestone Dec 17, 2024
Signed-off-by: chyezh <[email protected]>
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2e2f615 into milvus-io:2.4 Dec 18, 2024
15 checks passed
@chyezh chyezh deleted the fix_kafka_break_wal_sematics_2_4 branch December 18, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants