Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check target partition load state only when dropping partition #38375

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: Check target partition load state only when dropping partition #38375

merged 2 commits into from
Dec 11, 2024

Conversation

congqixia
Copy link
Contributor

Related to #38372

This PR make drop partition only check target partition load states only in case of concurrent releasing other partition in same collection.

@congqixia
fix: Check target partition load state only when dropping partition
0b13423 
Related to milvus-io#38372

This PR make drop partition only check target partition load states only
in case of concurrent releasing other partition in same collection.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. approved labels Dec 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (0d7a89a) to head (b58184e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/util.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38375      +/-   ##
==========================================
+ Coverage   80.90%   80.92%   +0.01%     
==========================================
  Files        1376     1376              
  Lines      192740   192933     +193     
==========================================
+ Hits       155938   156122     +184     
- Misses      31289    31293       +4     
- Partials     5513     5518       +5
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.92% <ø> (ø)
Go 83.03% <57.14%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/util.go 89.90% <57.14%> (-0.35%) ⬇️

... and 31 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Check not loaded error
b58184e 
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label Dec 11, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 304cdc7 into milvus-io:master Dec 11, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 12, 2024
@congqixia
fix: Check target partition load state only when dropping partition (m…
0920d70 
…ilvus-io#38375)

Related to milvus-io#38372

This PR make drop partition only check target partition load states only
in case of concurrent releasing other partition in same collection.

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Dec 12, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Dec 12, 2024
@congqixia
fix: [2.4] Check target partition load state only when dropping parti…
cacac66 
…tion (#38375) (#38394)

Cherry pick from master
pr: #38375
Related to #38372

This PR make drop partition only check target partition load states only
in case of concurrent releasing other partition in same collection.

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the fix/check_target_partid_only branch December 12, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @czs007 @sre-ci-robot