Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Check target partition load state only when dropping partition (#38375) #38394

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #38375
Related to #38372

This PR make drop partition only check target partition load states only in case of concurrent releasing other partition in same collection.


…ilvus-io#38375)

Related to milvus-io#38372

This PR make drop partition only check target partition load states only
in case of concurrent releasing other partition in same collection.

---------

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. approved labels Dec 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.40%. Comparing base (e959860) to head (0920d70).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/util.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38394      +/-   ##
==========================================
+ Coverage   79.44%   80.40%   +0.96%     
==========================================
  Files        1077     1077              
  Lines      169027   169022       -5     
==========================================
+ Hits       134277   135909    +1632     
+ Misses      30276    28654    -1622     
+ Partials     4474     4459      -15     
Files with missing lines Coverage Δ
internal/proxy/util.go 90.66% <57.14%> (-0.16%) ⬇️

... and 95 files with indirect coverage changes

@tedxu
Copy link
Contributor

tedxu commented Dec 12, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit cacac66 into milvus-io:2.4 Dec 12, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/38375 branch December 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants