Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: audio improvements #20

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: audio improvements #20

merged 3 commits into from
Jan 15, 2025

Conversation

rooooose-b
Copy link
Contributor

  • adds volume variable in config
  • adds custom sound variable in config
  • plays sound through SoundCategory.BLOCKS

@rooooose-b
Copy link
Contributor Author

rooooose-b commented Jan 8, 2025 •
edited
Loading

pr closes #19

additional context that could be good to have is that the custom sound in config has to match one of the sound events in sounds.json: https://minecraft.wiki/w/Sounds.json

changes are tested and working as intended locally.

@darksaid98 darksaid98 merged commit e17bd59 into milkdrinkers:main Jan 15, 2025
3 checks passed
@darksaid98 darksaid98 mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rooooose-b @darksaid98