Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve waitToSettle #102

Closed
wants to merge 1 commit into from
Closed

improve waitToSettle #102

wants to merge 1 commit into from

Conversation

mikeferguson
Copy link
Owner

  • add timeout parameter
  • do not busy wait

@mikeferguson
improve waitToSettle
595c0a4 
* add timeout parameter
* do not busy wait
mikeferguson
mikeferguson commented Jun 15, 2022
View reviewed changes
robot_calibration/src/chain_manager.cpp
}

// Exit if timed out
if (settling_timeout_ >= 0.0)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be > 0.0 not >=

@mikeferguson
Copy link
Owner Author

This was already added in ROS 2 - no longer have the ability to really test ROS 1

@mikeferguson mikeferguson deleted the settle_timeout branch December 11, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeferguson