Skip to content
This repository was archived by the owner on Aug 18, 2023. It is now read-only.

Conversation

Kanishka3
Copy link

What it Does

Hindi Localization

How I Tested

  • Change the App Language to Hindi in the scheme and tested the app.

Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kanishka3 I have a few questions, but good work!

Also net time don't erase anything in the PR template, just write "N/A" under any sections that aren't applicable

Comment on lines +18 to +19
"Edit" = "Edit";
"Done" = "Done";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested to know why Edit and Done aren't translated?

Copy link
Author

@Kanishka3 Kanishka3 Oct 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some words in hindi just don't have straight-up translations. Like "Edit" and "Cancel".

@mikaelacaron mikaelacaron added the hacktoberfest-accepted Accepted PR for Hacktoberfest label Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hacktoberfest-accepted Accepted PR for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants