Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Copying of Library List #1161

Merged
merged 16 commits into from
Feb 26, 2025
Merged

Allow Copying of Library List #1161

merged 16 commits into from
Feb 26, 2025

Conversation

Animeboynz
Copy link
Contributor

@Animeboynz Animeboynz commented Aug 26, 2024 •
edited
Loading

Closes #43

Screenshot_20240827_163532_Mihon

@AntsyLich
Copy link
Member

I'm more inclined towards share as csv instead of copy to clipboard

@Animeboynz
Copy link
Contributor Author

I'm more inclined towards share as csv instead of copy to clipboard

Ill do that as soon as I have AS working again

AntsyLich
AntsyLich requested changes Feb 23, 2025
View reviewed changes
Copy link
Member

@AntsyLich AntsyLich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And changelog

@Animeboynz
Copy link
Contributor Author

and here too

AntsyLich
AntsyLich requested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@AntsyLich AntsyLich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also where my co-author smh

AntsyLich
AntsyLich requested changes Feb 25, 2025
View reviewed changes
AntsyLich
AntsyLich reviewed Feb 26, 2025
View reviewed changes
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt Outdated
private fun ColumnSelectionDialog(
onDismissRequest: () -> Unit,
onConfirm: (ExportOptions) -> Unit,
currentOptions: ExportOptions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the first parameter

@AntsyLich AntsyLich enabled auto-merge (squash) February 26, 2025 05:04
@AntsyLich AntsyLich merged commit fab8b17 into mihonapp:main Feb 26, 2025
1 check passed
@Animeboynz Animeboynz deleted the LibraryListCopy branch February 26, 2025 05:09
@Animeboynz Animeboynz restored the LibraryListCopy branch February 26, 2025 05:10
@Animeboynz Animeboynz deleted the LibraryListCopy branch February 26, 2025 05:10
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Feb 26, 2025
@Animeboynz @cuong-tran
Add option to export minimal library information to a CSV file (mihon…
e006f1c 
…app/mihon#1161)

(cherry picked from commit fab8b17d99c44a08555b1f584c56d62a47737ca0)
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Feb 26, 2025
@Animeboynz @cuong-tran
Add option to export minimal library information to a CSV file (mihon…
013c40f 
…app/mihon#1161)

(cherry picked from commit fab8b17d99c44a08555b1f584c56d62a47737ca0)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AntsyLich AntsyLich AntsyLich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export Simple List Of Entries
2 participants
@Animeboynz @AntsyLich