Skip to content

Commit

Permalink
Even More Suggestions 😭
Browse files Browse the repository at this point in the history
Co-Authored-By: AntsyLich <[email protected]>
  • Loading branch information
Animeboynz and AntsyLich committed Feb 26, 2025
1 parent cdc4ca0 commit 5874773
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 15 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The format is a modified version of [Keep a Changelog](https://keepachangelog.co
- Add Monochrome theme (made with e-ink displays in mind) ([@MajorTanya](https://github.com/MajorTanya)) ([#1752](https://github.com/mihonapp/mihon/pull/1752))
- Support for private tracking with AniList and Bangumi ([@NarwhalHorns](https://github.com/NarwhalHorns)) ([#1736](https://github.com/mihonapp/mihon/pull/1736))
- Add private tracking support for Kitsu ([@MajorTanya](https://github.com/MajorTanya)) ([#1774](https://github.com/mihonapp/mihon/pull/1774))
- Add option to export minimal library information to a CSV file ([@Animeboynz](https://github.com/Animeboynz), [@AntsyLich](https://github.com/AntsyLich)) ([#1161](https://github.com/mihonapp/mihon/pull/1161))

### Changed
- Apply "Downloaded only" filter to all entries regardless of favourite status ([@NGB-Was-Taken](https://github.com/NGB-Was-Taken)) ([#1603](https://github.com/mihonapp/mihon/pull/1603))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ object SettingsDataScreen : SearchableSettings {
onDismissRequest = { showDialog = false },
onConfirm = { options ->
exportOptions = options
saveFileLauncher.launch("library_list.csv")
saveFileLauncher.launch("mihon_library.csv")
},
currentOptions = exportOptions,
)
Expand Down Expand Up @@ -408,9 +408,7 @@ object SettingsDataScreen : SearchableSettings {
},
text = {
Column {
Row(
verticalAlignment = Alignment.CenterVertically,
) {
Row(verticalAlignment = Alignment.CenterVertically) {
Checkbox(
checked = titleSelected,
onCheckedChange = { checked ->
Expand All @@ -424,9 +422,7 @@ object SettingsDataScreen : SearchableSettings {
Text(text = stringResource(MR.strings.title))
}

Row(
verticalAlignment = Alignment.CenterVertically,
) {
Row(verticalAlignment = Alignment.CenterVertically) {
Checkbox(
checked = authorSelected,
onCheckedChange = { authorSelected = it },
Expand All @@ -435,9 +431,7 @@ object SettingsDataScreen : SearchableSettings {
Text(text = stringResource(MR.strings.author))
}

Row(
verticalAlignment = Alignment.CenterVertically,
) {
Row(verticalAlignment = Alignment.CenterVertically) {
Checkbox(
checked = artistSelected,
onCheckedChange = { artistSelected = it },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ package eu.kanade.tachiyomi.data.export

import android.content.Context
import android.net.Uri
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import tachiyomi.domain.manga.model.Manga

Expand All @@ -27,9 +25,8 @@ object LibraryExporter {
context.contentResolver.openOutputStream(uri)?.use { outputStream ->
val csvData = generateCsvData(favorites, options)
outputStream.write(csvData.toByteArray())
outputStream.flush()
onExportComplete()
}
onExportComplete()
}
}

Expand All @@ -53,7 +50,7 @@ object LibraryExporter {
.let(::add)
}
}
return rows.joinToString("\n") { columns ->
return rows.joinToString("\r\n") { columns ->
columns.joinToString(",") columns@{ column ->
if (column.isNullOrBlank()) return@columns ""
if (escapeRequired.any { column.contains(it) }) {
Expand Down

0 comments on commit 5874773

Please sign in to comment.