Use core vscode*d.ts files for copilot extension

.github/workflows/pr.yml

@@ -284,10 +284,6 @@ jobs:
           mkdir -p .build/build_cache
           tar -czf .build/build_cache/cache.tgz --files-from .build/build_cache_list.txt
 
-      - name: Ensure proposed API types are up to date
-        working-directory: extensions/copilot
-        run: npm run vscode-dts:check
-
       - name: TypeScript type checking
         working-directory: extensions/copilot
         run: npm run typecheck

extensions/copilot/.github/workflows/pr.yml

@@ -121,9 +121,6 @@ jobs:
           mkdir -p .build/build_cache
           tar -czf .build/build_cache/cache.tgz --files-from .build/build_cache_list.txt
 
-      - name: Ensure proposed API types are up to date
-        run: npm run vscode-dts:check
-
       - name: TypeScript type checking
         run: npm run typecheck
 

extensions/copilot/chat-lib/package.json

@@ -34,7 +34,6 @@
 		"@anthropic-ai/sdk": "^0.82.0",
 		"@octokit/types": "^14.1.0",
 		"@types/node": "^22.16.3",
-		"@types/vscode": "^1.109.0",
 		"copyfiles": "^2.4.1",
 		"dotenv": "^17.2.0",
 		"npm-run-all": "^4.1.5",

extensions/copilot/package.json

@@ -6301,7 +6301,6 @@
 		"@types/source-map-support": "^0.5.10",
 		"@types/tar": "^6.1.13",
 		"@types/vinyl": "^2.0.12",
-		"@types/vscode": "^1.109.0",
 		"@types/vscode-webview": "^1.57.4",
 		"@types/yargs": "^17.0.24",
 		"@typescript-eslint/eslint-plugin": "^8.35.0",

extensions/copilot/script/build/extractChatLib.ts

@@ -634,21 +634,65 @@ class ChatLibExtractor {
 	}
 
 	private async copyVSCodeProposedTypes(): Promise<void> {
-		console.log('Copying VS Code proposed API types...');
+		console.log('Copying vscode*.d.ts files referenced by vscode-api.d.ts...');
 
-		// Find all vscode.proposed.*.d.ts files in src/extension/
-		const extensionDir = path.join(REPO_ROOT, 'src', 'extension');
-		const proposedTypeFiles = await glob('vscode.proposed.*.d.ts', { cwd: extensionDir });
+		const vscodeApiSrcPath = path.join(REPO_ROOT, 'src', 'extension', 'vscode-api.d.ts');
+		if (!fs.existsSync(vscodeApiSrcPath)) {
+			throw new Error(`vscode-api.d.ts not found at ${vscodeApiSrcPath}`);
+		}
 
-		for (const file of proposedTypeFiles) {
-			const srcPath = path.join(extensionDir, file);
-			const destPath = path.join(TARGET_DIR, '_internal', 'extension', file);
+		const content = await fs.promises.readFile(vscodeApiSrcPath, 'utf-8');
 
-			await fs.promises.mkdir(path.dirname(destPath), { recursive: true });
+		// Parse all /// <reference path="..." /> directives
+		const refRegex = /\/\/\/\s*<reference\s+path="([^"]+)"\s*\/>/g;
+		let match;
+		const referencedFiles: { refPath: string; fileName: string }[] = [];
+
+		while ((match = refRegex.exec(content)) !== null) {
+			const refPath = match[1];
+			const fileName = path.basename(refPath);
+			referencedFiles.push({ refPath, fileName });
+		}
+
+		// Copy each referenced .d.ts file from the vscode repo
+		const vscodeDtsDestDir = path.join(TARGET_DIR, '_internal', 'vscode-dts');
+		await fs.promises.mkdir(vscodeDtsDestDir, { recursive: true });
+
+		for (const { refPath, fileName } of referencedFiles) {
+			// Resolve the reference path relative to the source file
+			const srcPath = path.resolve(path.dirname(vscodeApiSrcPath), refPath);
+			if (!fs.existsSync(srcPath)) {
+				console.warn(`Warning: Referenced file not found: ${srcPath}`);
+				continue;
+			}
+
+			const destPath = path.join(vscodeDtsDestDir, fileName);
 			await fs.promises.copyFile(srcPath, destPath);
 		}
 
-		console.log(`Copied ${proposedTypeFiles.length} VS Code proposed API type files`);
+		// Copy vscode-api.d.ts itself, updating reference paths
+		const updatedContent = content.replace(
+			/\/\/\/\s*<reference\s+path="([^"]+)"\s*\/>/g,
+			(_match, refPath: string) => {
+				const fileName = path.basename(refPath);
+				return `/// <reference path="./vscode-dts/${fileName}" />`;
+			}
+		);
+
+		const vscodeApiDestPath = path.join(TARGET_DIR, '_internal', 'vscode-api.d.ts');
+		await fs.promises.writeFile(vscodeApiDestPath, updatedContent);
+
+		// Also copy thenable.d.ts which is referenced by vscode.d.ts
+		const vscodeRepoRoot = path.join(REPO_ROOT, '..', '..');
+		const thenableSrcPath = path.join(vscodeRepoRoot, 'src', 'typings', 'thenable.d.ts');
+		if (fs.existsSync(thenableSrcPath)) {
+			await fs.promises.copyFile(thenableSrcPath, path.join(vscodeDtsDestDir, 'thenable.d.ts'));
+			console.log('Copied thenable.d.ts');
+		} else {
+			console.warn(`Warning: thenable.d.ts not found at ${thenableSrcPath}`);
+		}
+
+		console.log(`Copied vscode-api.d.ts and ${referencedFiles.length} referenced .d.ts files`);
 	}
 
 	private async copyTikTokenFiles(): Promise<void> {
@@ -871,4 +915,4 @@ async function main(): Promise<void> {
 
 if (require.main === module) {
 	main();
-}
+}

extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts

@@ -1256,7 +1256,11 @@ export class CopilotCLIChatSessionParticipant extends Disposable {
 							resource: request.sessionResource,
 						},
 						isUntitled: false,
-						initialSessionOptions: undefined
+						initialSessionOptions: undefined,
+						inputState: {
+							groups: [],
+							onDidChange: Event.None
+						}
 					};
 					context = {
 						chatSessionContext,

extensions/copilot/src/extension/conversation/vscode-node/conversationFeature.ts

@@ -253,7 +253,7 @@ export class ConversationFeature implements IExtensionContribution {
 					vscode.window.activeTerminal?.sendText(message, false);
 				}
 			}),
-			vscode.commands.registerCommand('github.copilot.git.generateCommitMessage', async (rootUri: vscode.Uri | undefined, _: vscode.SourceControlInputBoxValueProviderContext[], cancellationToken: vscode.CancellationToken | undefined) => {
+			vscode.commands.registerCommand('github.copilot.git.generateCommitMessage', async (rootUri: vscode.Uri | undefined, _: unknown, cancellationToken: vscode.CancellationToken | undefined) => {
 				const repository = await this.gitCommitMessageService.getRepository(rootUri);
 				if (!repository) {
 					return;

extensions/copilot/src/extension/intents/node/editCodeIntent.ts

@@ -499,13 +499,7 @@ export class EditCodeIntentInvocation implements IIntentInvocation {
 			}
 		}
 
-		const isReadonly = this.request.references.some(r => r.isReadonly && URI.isUri(r.value) && isEqual(r.value, uri));
-		if (isReadonly) {
-			return {
-				title: l10n.t`Allow edits to readonly file?`,
-				message: l10n.t`Do you want to allow edits to \`${this.workspaceService.asRelativePath(uri)}\`?`,
-			};
-		}
+		return undefined;
 	}
 
 	async processResponse?(context: IResponseProcessorContext, inputStream: AsyncIterable<IResponsePart>, outputStream: vscode.ChatResponseStream, token: vscode.CancellationToken): Promise<vscode.ChatResult> {

extensions/copilot/src/extension/prompt/common/chatVariablesCollection.ts

@@ -57,7 +57,7 @@ export class ChatVariablesCollection {
 				if (variable.value) {
 					const originalName = variable.name;
 					const uniqueName = this.uniqueFileName(originalName, this._source.slice(0, i));
-					this._variables.push({ reference: variable, originalName, uniqueName, value: variable.value, range: variable.range, isMarkedReadonly: variable.isReadonly });
+					this._variables.push({ reference: variable, originalName, uniqueName, value: variable.value, range: variable.range, isMarkedReadonly: false });
 				}
 			}
 		}