Skip to content

Use core vscode*d.ts files for copilot extension#308841

Open
mjbvz wants to merge 9 commits intomainfrom
dev/mjbvz/potential-narwhal
Open

Use core vscode*d.ts files for copilot extension#308841
mjbvz wants to merge 9 commits intomainfrom
dev/mjbvz/potential-narwhal

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Apr 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 9, 2026 18:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches the Copilot extension’s TypeScript typing source for the VS Code API (stable + proposed) from locally vendored vscode.proposed.*.d.ts files to the repo’s canonical src/vscode-dts/* definitions, reducing duplication and keeping the extension aligned with core.

Changes:

  • Add extensions/copilot/src/vscode-api.d.ts that triple-slash references src/vscode-dts/vscode.d.ts plus the set of proposed API .d.ts files the extension relies on.
  • Remove many locally maintained extensions/copilot/src/extension/vscode.proposed.*.d.ts files and the old proposed-dts maintenance scripts/CI check.
  • Adjust a few call sites/types to account for API typing changes (e.g. dropped isReadonly usage, updated ChatContext shape, command arg type loosening).
Show a summary per file
File Description
extensions/copilot/tsconfig.worker.json JSON formatting-only changes to lib/exclude arrays.
extensions/copilot/tsconfig.json Stop including a vscode ambient types package; keep a vscode path shim for tests.
extensions/copilot/src/vscode-api.d.ts New central reference file pointing to core src/vscode-dts stable + proposed API definitions.
extensions/copilot/src/extension/**/vscode.proposed.*.d.ts Remove locally vendored proposed API declaration files in favor of core ones.
extensions/copilot/src/extension/prompt/common/chatVariablesCollection.ts Drop isReadonly propagation (no longer present in core typings).
extensions/copilot/src/extension/intents/node/editCodeIntent.ts Remove readonly-reference edit confirmation logic (API no longer exposes isReadonly).
extensions/copilot/src/extension/conversation/vscode-node/conversationFeature.ts Loosen unused command arg type where the API type no longer exists.
extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts Provide inputState in chatSessionContext to satisfy updated typing expectations.
extensions/copilot/script/** Remove scripts that downloaded/checked vendored proposed .d.ts files.
extensions/copilot/chat-lib/package.json Remove @types/vscode devDependency (but lockfile needs updating).
extensions/copilot/.github/workflows/pr.yml Remove the “proposed API types up to date” CI step.

Copilot's findings

Files not reviewed (1)
  • extensions/copilot/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

extensions/copilot/chat-lib/package.json:40

  • @types/vscode was removed from chat-lib's devDependencies, but extensions/copilot/chat-lib/package-lock.json still contains entries for it. Please regenerate/update the lockfile so installs remain deterministic (and so npm ci doesn't fail if run in chat-lib).
	"devDependencies": {
		"@anthropic-ai/sdk": "^0.82.0",
		"@octokit/types": "^14.1.0",
		"@types/node": "^22.16.3",
		"copyfiles": "^2.4.1",
		"dotenv": "^17.2.0",
		"npm-run-all": "^4.1.5",
		"outdent": "^0.8.0",
  • Files reviewed: 13/80 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Screenshot Changes

Base: 56f60d48 Current: 805efebe

Changed (1)

editor/inlineChatAffordance/InlineChatOverlay/Light
Before After
before after

@mjbvz mjbvz enabled auto-merge April 9, 2026 22:21
@mjbvz mjbvz disabled auto-merge April 9, 2026 22:22
@mjbvz mjbvz enabled auto-merge April 9, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants