Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit wise reviews #4315

Open
ldelossa opened this issue Dec 11, 2022 · 1 comment
Open

Commit wise reviews #4315

ldelossa opened this issue Dec 11, 2022 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@ldelossa
Copy link

Hello,

Currently there is poor support for the common use case of commit-wise reviewing.

In a commit-wise review, each commit should be viewable and each file within a commit should be able to have comments applied to them.

In addition, when a commit is being viewed, the local repository should be checked out to that commit object. This allows for the editor not to force read-only on the file. Forcing read-only stops the use of any LSP tools and the ability to navigate the changes that occurred within a PR.

I'd like to see better support for commit-wise reviews with the above taken into account.

@davidrinnan
Copy link

davidrinnan commented Jun 29, 2023

Especially given that in a scenario where:

  • branch A from master, commits changes, creates PR-A
  • branch B from branch A, commits changes, creates PR-B

Reviewer review PR-B, approves and merges with master.

It will now look like PR-A has been merged without being reviewed. Even though I have reviewed everything in PR-B which includes everything in PR-A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants