Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review of PR - would like to be able to choose/limit which commits are being reviewed #4959

Closed
davidrinnan opened this issue Jun 26, 2023 · 1 comment
Closed

Code review of PR - would like to be able to choose/limit which commits are being reviewed #4959

davidrinnan opened this issue Jun 26, 2023 · 1 comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@davidrinnan
Copy link

Sometimes we have multiple PRs where some of them has been checked out from another PR.

In those cases, as a reviewer, you want to be able to limit the review to the branch commits. Otherwise many of the reviews will include code supposed to be reviewed in another PR making it difficult to review.

This is possible to do when reviewing code via github in the browser. This control could exist on the overview/description page of the PR in visual code.
@alexr00
Copy link
Member

alexr00 commented Jun 28, 2023

Duplicate of #4315

@alexr00 alexr00 marked this as a duplicate of #4315 Jun 28, 2023
@alexr00 alexr00 closed this as completed Jun 28, 2023
@alexr00 alexr00 added *duplicate Issue identified as a duplicate of another issue(s) and removed duplicate labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidrinnan @alexr00