You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context information - Extension version
0.86.1 (current) - VSCODE version
github.dev vscode web browser from a git repo activated. - OS & more
Version: 1.88.1
Date: 2024-04-10T17:36:48.184Z (2 wks ago)
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36
- Repository Clone Configuration
Single repository - Github Product (Github.com/Github Enterprise version x.x.x):
Github.com
Steps to Reproduce:
When on a github repo, press the "dot" . key to activate github.dev vscode browser version
When you do this while on a pullrequest, it will open said pull request in the vscode browser version
You then get an extra Tab icon on the side named exactly "Github pull request"
This shows you 2 view options, either a file list of all changed files,
or you can browse each file Per commit
I prefer to browse the PR using the "commits" view, but then when you hover over the sidebar, you dont get the option to comment
However if you use the "files" view, you do get the option for said + hover to add a comment
I can understand that the difference between the file list, and the commit list. Is that the file you are viewing is the "final" version of the file, but it would sure be nice if while browsing the commits from the commitlist i could add the comment there, instead of having to switch back to the filelist, find whatever file i just had open in the commit list and then comment in the place i wanted.
Proposed solution:
add the option to add comments to the commitlist aswell
To solve the "viewing a file that is different from the final version in the PR" only accept placing comments on files that remain unchanged in the rest of the PR? Since the line numbers would be different if you would want to handle placing comments on older versions of files
The text was updated successfully, but these errors were encountered:
Context information
- Extension version
0.86.1 (current)
- VSCODE version
github.dev vscode web browser from a git repo activated.
- OS & more
Version: 1.88.1
Date: 2024-04-10T17:36:48.184Z (2 wks ago)
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36
- Repository Clone Configuration
Single repository
- Github Product (Github.com/Github Enterprise version x.x.x):
Github.com
Steps to Reproduce:
This shows you 2 view options, either a file list of all changed files,
or you can browse each file Per commit
However if you use the "files" view, you do get the option for said + hover to add a comment
I can understand that the difference between the file list, and the commit list. Is that the file you are viewing is the "final" version of the file, but it would sure be nice if while browsing the commits from the commitlist i could add the comment there, instead of having to switch back to the filelist, find whatever file i just had open in the commit list and then comment in the place i wanted.
Proposed solution:
The text was updated successfully, but these errors were encountered: