-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Integrate RN Nightly Build 0.80.0-nightly-20250428-9efcdc091 #14844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate RN Nightly Build 0.80.0-nightly-20250428-9efcdc091 #14844
Conversation
...ft.ReactNative/Fabric/platform/react/renderer/textlayoutmanager/WindowsTextLayoutManager.cpp
Outdated
Show resolved
Hide resolved
Can you run |
Looks like all the tests are failing because the lock file needs to be updated. Can you run |
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputShadowNode.cpp
Show resolved
Hide resolved
@jonthysell / @sharath2727 change files are needed for CI pipelines to run |
@sharath2727 and @vineethkuttan linting and many other issues are here that can be fixed like incorrect overrides
Found overrides whose original files have changed. Upgrade overrides using 'npx react-native-platform-override upgrade':
error Command failed with exit code 1. ##[error]Bash exited with code '1'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI errors that can be resolved
@@ -17,11 +17,11 @@ | |||
"sample-custom-component": "0.0.1" | |||
}, | |||
"peerDependencies": { | |||
"@react-native-picker/picker": "2.4.10", | |||
"@react-native-picker/picker": "2.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this upgrade should be okay; but if you run into issues you can revert to the previous version
"Visual Type": "SpriteVisual", | ||
}, | ||
"Component Tree": {}, | ||
"Visual Tree": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I wouldn't expect these to be empty. Can you open the LegacyControlStyleTest.js file in playground-composition and see if the content is rendering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed it.
Description
Integrate RN Nightly Build 0.80.0-nightly-20250428-9efcdc091
Commit Range
facebook/react-native@70cdf12...9efcdc0
Changelog
no
#14848
Microsoft Reviewers: Open in CodeFlow