-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IRangeValueProvider #12356
Draft
YajurG
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
YajurG:YajurG-range-value-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+118
−3
Draft
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5e9e1d0
initial rangevalueprovider changes
Yajur-Grover 416dcb1
Change files
Yajur-Grover abdbb9f
fixed syntax issues
Yajur-Grover 874a34b
changed temp return values
Yajur-Grover e10b31a
fixed errors
Yajur-Grover aa824ce
formatting fix
Yajur-Grover 560e408
fixed logic for patternId
Yajur-Grover 4bf6ba9
Merge branch 'main' into YajurG-range-value-provider
chiaramooney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
changed temp return values
commit 874a34b571e0af4861f6513816162481338b5aae
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -424,6 +424,7 @@ HRESULT __stdcall CompositionDynamicAutomationProvider::get_LargeChange(double * | |
if (pRetVal == nullptr) | ||
return E_POINTER; | ||
|
||
*pRetVal = std::numeric_limits<double>::quiet_NaN(); | ||
return S_OK; | ||
} | ||
|
||
|
@@ -458,6 +459,8 @@ HRESULT __stdcall CompositionDynamicAutomationProvider::get_Minimum(double *pRet | |
HRESULT __stdcall CompositionDynamicAutomationProvider::get_SmallChange(double *pRetVal) { | ||
if (pRetVal == nullptr) | ||
return E_POINTER; | ||
|
||
*pRetVal = std::numeric_limits<double>::quiet_NaN(); | ||
return S_OK; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should return quiet NaN |
||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are not going to implement this, you should return quiet NaN:
https://learn.microsoft.com/en-us/windows/win32/api/uiautomationcore/nf-uiautomationcore-irangevalueprovider-get_largechange