Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IRangeValueProvider #12356

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changed temp return values
Yajur-Grover committed Nov 7, 2023
commit 874a34b571e0af4861f6513816162481338b5aae
4 changes: 3 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -17,7 +17,9 @@
"utility": "cpp",
"ratio": "cpp",
"memory": "cpp",
"array": "cpp"
"array": "cpp",
"optional": "cpp",
"limits": "cpp"
},
"search.exclude": {
"**/dist/**/*.js": true,
Original file line number Diff line number Diff line change
@@ -424,6 +424,7 @@ HRESULT __stdcall CompositionDynamicAutomationProvider::get_LargeChange(double *
if (pRetVal == nullptr)
return E_POINTER;

*pRetVal = std::numeric_limits<double>::quiet_NaN();
return S_OK;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

@@ -458,6 +459,8 @@ HRESULT __stdcall CompositionDynamicAutomationProvider::get_Minimum(double *pRet
HRESULT __stdcall CompositionDynamicAutomationProvider::get_SmallChange(double *pRetVal) {
if (pRetVal == nullptr)
return E_POINTER;

*pRetVal = std::numeric_limits<double>::quiet_NaN();
return S_OK;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should return quiet NaN

}