Implement IRangeValueProvider #12356
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
reviewed
Nov 6, 2023
|
|
||
|
|
||
|
|
||
| return S_OK; |
There was a problem hiding this comment.
If you are not going to implement this, you should return quiet NaN:
https://learn.microsoft.com/en-us/windows/win32/api/uiautomationcore/nf-uiautomationcore-irangevalueprovider-get_largechange
| HRESULT __stdcall CompositionDynamicAutomationProvider::get_SmallChange(double *pRetVal) { | ||
| if (pRetVal == nullptr) | ||
| return E_POINTER; | ||
| return S_OK; |
| @@ -158,6 +158,13 @@ HRESULT __stdcall CompositionDynamicAutomationProvider::GetPatternProvider(PATTE | |||
| AddRef(); | |||
| } | |||
|
|
|||
| if (patternId == UIA_RangeValuePatternId) { | |||
| *pRetVal = static_cast<IRangeValueProvider *>(this); | |||
There was a problem hiding this comment.
We should probably only return this pattern if the role is set to something that aligns with this pattern.
There was a problem hiding this comment.
Shouldn't we also do a role check for UIA_ValuePatternId as well (i.e if the role is not 'adjustable' or 'progressbar' since those roles correspond to RangeValuePattern?
There was a problem hiding this comment.
Yea i think we'll want roles checks for each of these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Why
Implements the IRangeValueProvider and supporting methods which is used to provide support for controls that can be set to a value within a range.
What
Implemented SetValue, get_Value, get_Minimum and get_Maximum methods as part of the IRangeValueProvider interface.
TODO: implment get_SmallChange and get_LargeChange.
Screenshots
After:
Testing
Tested locally on playground.
Changelog
Yes