fix(test runner): forward the screen option from device descriptors - #42681
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
Test results for "tests 1"4 flaky51698 passed, 1247 skipped Merge workflow run. |
Test results for "MCP"1 failed 8495 passed, 1436 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 CI is clear — the one failure is a pre-existing flakeThe only red test, DetailsOverall: nothing here points back at the diff. The PR adds a Pre-existing flake / infra
Already-retried flakes (passed on retry, not blocking)
None of these exercise the Triaged by the Playwright bot - agent run |
Summary
screenas a test option sotest.use({ ...devices[...] })anduse: { ...devices[...] }in config forward the descriptor'sscreenkey, matching library mode.TestOptions.screentype and docs entry, plus a regression test.Fixes #42679
Breaking change, not for landing
Every config that spreads a device descriptor into
usestarts emulatingscreenon upgrade. That includes all desktop descriptors, so the default scaffolded project changeswindow.screenfrom 1280x720 to 1920x1080 anddevice-widthmedia queries follow. A user-defined fixture namedscreenthat depends onpagenow fails with a fixture dependency cycle, which affects@playwright-testing-library/test.