Skip to content

feat(chromium): roll to r1245 - #42683

Merged
Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-chromium/1245
Sep 14, 2026
Merged

Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-chromium/1245

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/4e06c7226b492be89bfc41b9676ee1e98d9cea13. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51691 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/webmcp.spec.ts:178 › browser_webmcp_call disambiguates duplicate tool names by frame @mcp-macos-latest-chrome
❌ [chromium] › mcp/webmcp.spec.ts:213 › browser_webmcp_call disambiguates same-name tools in identical same-origin frames @mcp-macos-latest-chromium

8494 passed, 1436 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Both failures are a pre-existing flake — the roll is clear

Hi, I'm the Playwright bot and I took a look at the red CI here.

The two mcp/webmcp.spec.ts failures are a freshly-flaky test, not the r1245 roll. The same two tests failed in the same window on two push runs (d1ead3ec, 6750decc) that have no PR attached at all, and on unrelated PRs #42668 and #42681. One of the failures is also on the [chrome] project, which runs stable Google Chrome — a channel browsers.json doesn't touch.

Details

This PR changes one file, packages/playwright-core/browsers.json, bumping the Chromium revision. The only plausible blast radius is Chromium-family behaviour, so Chromium-only MCP failures were worth a hard look — but the history rules them out.

Pre-existing flake / infra

  • [chrome] › mcp/webmcp.spec.ts:178 › browser_webmcp_call disambiguates duplicate tool names by frame and [chromium] › mcp/webmcp.spec.ts:213 › browser_webmcp_call disambiguates same-name tools in identical same-origin frames — both flake on SHAs this PR can't be responsible for. Across the aggregated CI results, the :178/:213 pair on chrome/chromium has a failed attempt in 6 runs, and 4 of those are nothing to do with this PR:

    test run sha / PR
    chromium:178 34656353189 d1ead3ec, push
    chrome:213 34650183469 6750decc, push
    chromium:178 34655556923 f1b2e328, feat(mcp): add media emulation #42668
    chrome:213 34652593334 3ff52f2d, fix(test runner): forward the screen option from device descriptors #42681

    The verdict also flips: over 27 runs each, chrome:178, chrome:213, chromium:178 and chromium:213 all end green far more often than not, and on this PR's earlier run (51a4b958) a retry rescued them. The error is a frame-enumeration race — the tool is found in one frame instead of two (Found 1 WebMCP tool(s) vs the expected 2, and "error": undefined where the multi-frame message was expected), i.e. the assertion runs before both frames have registered. All of it is on mcp-macos-latest-*.

Nothing to triage in "tests 1"

That job reports 5 flaky and 0 failed (51691 passed). Two of the five are Firefox cookie tests and one is a Firefox request test, which a Chromium roll cannot reach.

Worth saying plainly: I only have history up to the snapshot, and the head SHA d859d042 run wasn't ingested yet, so the per-run numbers above come from this PR's previous SHA and its neighbours. That doesn't change the call — the push-run failures are the part that settles it.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

2 failed
❌ [android-page] › page/page-click-scroll.spec.ts:160 › should scroll instantly on retry when scroll-behavior is smooth
❌ [android-page] › page/page-click.spec.ts:1030 › should not retain removed iframe after clicking inside it

33 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@tracing-chromium`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@tracing-chromium`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@chromium-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:121 › selector generator › should fall back to nth when name and description are both not unique `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:175 › selector generator › should not improve guid text `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:467 › selector generator › should match in deep shadow dom `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:617 › selector generator › should generate exact title when necessary `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:683 › selector generator › should generate noText: name from aria-label `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/hit-target.spec.ts:259 › should not click an element overlaying iframe with the target `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:28 › should print the correct imports and context options `@firefox-macos-15-large`
⚠️ [firefox-page] › page/expect-boolean.spec.ts:93 › toBeChecked › fail with checked:false `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:170 › should make a copy of default viewport `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-viewport.spec.ts:25 › should get the proper default viewport size `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1987 › canvas disabled title `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames fit `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames scale `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak `@webkit-macos-15-xlarge`
⚠️ [android-page] › page/page-autowaiting-no-hang.spec.ts:53 › calling window.open and window.close
⚠️ [android-page] › page/page-request-fulfill.spec.ts:81 › should fulfill with unuassigned status codes

111289 passed, 4738 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Both failures are pre-existing Android breakage — this roll is clear

Hi, I'm the Playwright bot and I triaged the CI failures here.

The two [android-page] failures are broken on main, not caused by r1245. Neither test has passed
in any run in the CI results DB, and both were already failing on unrelated SHAs before this PR's
commit (d859d04) existed. Everything else in the report is flaky-only.

Details

Pre-existing flake / infra

  • [android-page] › page/page-click-scroll.spec.ts:160 › should scroll instantly on retry when scroll-behavior is smooth — permanently red, not a flake: 0 passes in 35 runs. It fails on 33 other SHAs across 6 different PRs, first seen 2026-09-08, well before this roll. Signature is stable everywhere: page.click: Timeout 30000ms exceeded with <div id="header"></div> intercepts pointer events on every retry.

  • [android-page] › page/page-click.spec.ts:1030 › should not retain removed iframe after clicking inside it — same story: 0 passes in 14 runs, failing on 14 other SHAs across 2 PRs since 2026-09-10. Always the same assertion, expect(received).toBe(expected)Expected: false, Received: true.

Both run against Chrome on the Android device, which doesn't consume the browsers.json Chromium
revision this PR bumps, so there's no path from the diff to these tests anyway.

Not failures

The 33 flaky entries all passed on retry and are spread across chromium/firefox/webkit tracing,
screencast, cookie and selector-generator suites — nothing a browsers.json bump would touch.

Triaged by the Playwright bot - agent run

@dcrousso
Devin Rousso (dcrousso) merged commit a9da2db into main Sep 14, 2026
72 of 75 checks passed
@dcrousso
Devin Rousso (dcrousso) deleted the roll-into-pw-chromium/1245 branch September 14, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant