openhcl_boot: Serial output in the boot shim in SNP #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
May 19, 2025
jstarks
reviewed
May 19, 2025
mebersol
added
the
backport_2505
|
Don't approve just yet folks, will look more at the page acceptance code to make sure it matches the manuals. |
jstarks
reviewed
May 21, 2025
jstarks
reviewed
May 21, 2025
jstarks
reviewed
May 21, 2025
jstarks
reviewed
May 21, 2025
|
@jstarks Addressed your comments, appreciated very much! |
jstarks
reviewed
May 21, 2025
jstarks
reviewed
May 21, 2025
jstarks
reviewed
May 21, 2025
found a way to rseolve |
That might be useful in other scenarios where running virtually baremetal.
romank-msft
force-pushed
the
bootshim_snp_log
branch
from
f2b16db to
bec41c0
Compare
romank-msft
force-pushed
the
bootshim_snp_log
branch
from
bec41c0 to
1648e44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be useful in other scenarios when running virtually baremetal SNP-isolated.
All the machinery inside VTL2 works (mapping the GHCB page, (un)accepting, doing GHCB calls), and the host prints the logs from the boot shim running in SNP.