Skip to content

simd_norm input parameters update #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zehonyi21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

simd_norm input parameters update #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion mx/simd_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
simd_reduce_mean y = x.mean(dim)
simd_norm y = (x**2).sum().sqrt()
"""
from typing import Any, Optional, TYPE_CHECKING, Union

import torch
import torch.nn as nn
import torch.nn.functional as F
Expand Down Expand Up @@ -540,7 +542,14 @@ def simd_reduce_mean(in1, dim=None, keepdim=False, mx_specs=None):
return SIMDMul.apply(s, 1/denom, mx_specs)


def simd_norm(in1, keepdim=False, mx_specs=None):
def simd_norm(
in1,
p: Optional[Union[float, str]] = "fro",
dim=None,
keepdim=False,
dtype=None,
mx_specs=None,
):
""" Computes Frobenius norm sqrt(sum(in1**2)), same as
torch.linalg.norm(in1) with no other args """
mx_assert_test(mx_specs)
Expand Down