simd_norm input parameters update #41
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current input parameters for simd_norm are not consistent with those of 'torch.norm'(refer to https://docs.pytorch.org/docs/stable/generated/torch.norm.html) thus I changed it accordingly
* note that my pytorch does not require 'out' as input paramters so I didn't add it (return torch.norm(self, p, dim, keepdim, dtype=dtype))