Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control generated types access modifier for C# #5284

Merged

Commits on Sep 12, 2024

  1. Control generated class access modifier for C#

    - Add `--class-access-modifier` flag.
    NKnusperer committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ed82db3 View commit details
    Browse the repository at this point in the history
  2. Review feedback

    - Rename `--class-access-modifier` to `--type-access-modifier`.
    - Use `AccessModifier` enum instead of string and extend to `Internal` value.
    - Add `Access` property to `CodeClass` and `CodeEnum`.
    - Use `CSharpRefiner` to set `Access` property from configuration.
    - Extend `CodeClassDeclarationWriter` and `CodeEnumWriter` to write actual type access modifier.
    NKnusperer committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ca0dadb View commit details
    Browse the repository at this point in the history
  3. Review feedback 2

    - Add `TypeAccessModifierOption` to client handlers.
    - Add `TypeAccessModifier` to workspace `ApiClientConfiguration` and `ApiClientConfigurationComparer`.
    - Add default value of `Public` for stringified `TypeAccessModifier` properties.
    - Add test case for `CSharpRefiner`.
    - Implement `IAccessibleElement` for `CodeClass` and `CodeEnum`.
    NKnusperer committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1fb471a View commit details
    Browse the repository at this point in the history
  4. Review feedback 3

    - Use parenthesized pattern matching for type checks.
    NKnusperer committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e6ec1b6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    307258a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    1bc2715 View commit details
    Browse the repository at this point in the history
  2. chore: runs dotnet format

    baywet committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    79de4eb View commit details
    Browse the repository at this point in the history
  3. fix: failing hashcode test

    baywet committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c6cbfe7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d0ebaa1 View commit details
    Browse the repository at this point in the history