-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control generated types access modifier for C# #5284
Merged
baywet
merged 9 commits into
microsoft:main
from
NKnusperer:feature/4788-csharp-class-access-modifier
Sep 13, 2024
Merged
Control generated types access modifier for C# #5284
baywet
merged 9 commits into
microsoft:main
from
NKnusperer:feature/4788-csharp-class-access-modifier
Sep 13, 2024
Commits on Sep 12, 2024
-
Control generated class access modifier for C#
- Add `--class-access-modifier` flag.
Configuration menu - View commit details
-
Copy full SHA for ed82db3 - Browse repository at this point
Copy the full SHA ed82db3View commit details -
- Rename `--class-access-modifier` to `--type-access-modifier`. - Use `AccessModifier` enum instead of string and extend to `Internal` value. - Add `Access` property to `CodeClass` and `CodeEnum`. - Use `CSharpRefiner` to set `Access` property from configuration. - Extend `CodeClassDeclarationWriter` and `CodeEnumWriter` to write actual type access modifier.
Configuration menu - View commit details
-
Copy full SHA for ca0dadb - Browse repository at this point
Copy the full SHA ca0dadbView commit details -
- Add `TypeAccessModifierOption` to client handlers. - Add `TypeAccessModifier` to workspace `ApiClientConfiguration` and `ApiClientConfigurationComparer`. - Add default value of `Public` for stringified `TypeAccessModifier` properties. - Add test case for `CSharpRefiner`. - Implement `IAccessibleElement` for `CodeClass` and `CodeEnum`.
Configuration menu - View commit details
-
Copy full SHA for 1fb471a - Browse repository at this point
Copy the full SHA 1fb471aView commit details -
- Use parenthesized pattern matching for type checks.
Configuration menu - View commit details
-
Copy full SHA for e6ec1b6 - Browse repository at this point
Copy the full SHA e6ec1b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 307258a - Browse repository at this point
Copy the full SHA 307258aView commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1bc2715 - Browse repository at this point
Copy the full SHA 1bc2715View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79de4eb - Browse repository at this point
Copy the full SHA 79de4ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6cbfe7 - Browse repository at this point
Copy the full SHA c6cbfe7View commit details -
fix: missing default value for add/generate command access modifier
Signed-off-by: Vincent Biret <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d0ebaa1 - Browse repository at this point
Copy the full SHA d0ebaa1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.