Control generated types access modifier for C# #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Enum support is still missing, |
andrueastman
reviewed
Sep 3, 2024
NKnusperer
changed the title
baywet
reviewed
Sep 4, 2024
NKnusperer
force-pushed
the
feature/4788-csharp-class-access-modifier
branch
from
d8c57cf
to
b79a202
Compare
andrueastman
reviewed
Sep 9, 2024
calebkiage
reviewed
Sep 9, 2024
baywet
reviewed
Sep 10, 2024
- Add `--class-access-modifier` flag.
- Rename `--class-access-modifier` to `--type-access-modifier`. - Use `AccessModifier` enum instead of string and extend to `Internal` value. - Add `Access` property to `CodeClass` and `CodeEnum`. - Use `CSharpRefiner` to set `Access` property from configuration. - Extend `CodeClassDeclarationWriter` and `CodeEnumWriter` to write actual type access modifier.
- Add `TypeAccessModifierOption` to client handlers. - Add `TypeAccessModifier` to workspace `ApiClientConfiguration` and `ApiClientConfigurationComparer`. - Add default value of `Public` for stringified `TypeAccessModifier` properties. - Add test case for `CSharpRefiner`. - Implement `IAccessibleElement` for `CodeClass` and `CodeEnum`.
- Use parenthesized pattern matching for type checks.
NKnusperer
force-pushed
the
feature/4788-csharp-class-access-modifier
branch
from
814ae26
to
307258a
Compare
baywet
previously approved these changes
Sep 13, 2024
baywet
previously approved these changes
Sep 13, 2024
Signed-off-by: Vincent Biret <[email protected]>
baywet
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--type-access-modifierflag.Fixes #4788.