Remove XDP_TEST hook and program type in ebpf-for-windows #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarvin123
changed the title
kumarvin123
changed the title
kumarvin123
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
kumarvin123
force-pushed
the
user/vinodko/XdpTestExtensionRemoval
branch
6 times, most recently
from
a87fe8a to
0f1c3a3
Compare
kumarvin123
requested review from
Alan-Jowett,
LakshK98,
dthaler,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
dthaler
reviewed
Sep 27, 2025
shankarseal
reviewed
Sep 29, 2025
kumarvin123
force-pushed
the
user/vinodko/XdpTestExtensionRemoval
branch
4 times, most recently
from
20c7d21 to
28aa1c6
Compare
dthaler
reviewed
Oct 1, 2025
matthewige
previously approved these changes
Oct 1, 2025
kumarvin123
force-pushed
the
user/vinodko/XdpTestExtensionRemoval
branch
from
b2a3f75 to
3ca5dfb
Compare
matthewige
approved these changes
Oct 3, 2025
dthaler
approved these changes
Oct 3, 2025
8 tasks
lmb
added a commit
to lmb/ebpf
that referenced
this pull request
Oct 14, 2025
The upstream efW removed the XDP_TEST program type from the repository. We rely on this type for our unit tests. Switch tests to the SAMPLE program type, which is a separate driver but also distributed as part of the efW runtime. On Windows, running a SAMPLE program requires providing a (possibly empty) context. To avoid having to change a lot of our unit tests we make Program.Test and Program.Benchmark provide such empty buffers. See: microsoft/ebpf-for-windows#4662 Signed-off-by: Lorenz Bauer <[email protected]>
lmb
added a commit
to lmb/ebpf
that referenced
this pull request
Oct 14, 2025
The upstream efW removed the XDP_TEST program type from the repository. We rely on this type for our unit tests. Switch tests to the SAMPLE program type, which is a separate driver but also distributed as part of the efW runtime. On Windows, running a SAMPLE program requires providing a (possibly empty) context. To avoid having to change a lot of our unit tests we make Program.Test and Program.Benchmark provide such empty buffers. See: microsoft/ebpf-for-windows#4662 Signed-off-by: Lorenz Bauer <[email protected]>
lmb
added a commit
to lmb/ebpf
that referenced
this pull request
Oct 16, 2025
The upstream efW removed the XDP_TEST program type from the repository. We rely on this type for our unit tests. Switch tests to the SAMPLE program type, which is a separate driver but also distributed as part of the efW runtime. On Windows, running a SAMPLE program requires providing a (possibly empty) context. To avoid having to change a lot of tests over and over we introduce a new mustRun helper. See: microsoft/ebpf-for-windows#4662 Signed-off-by: Lorenz Bauer <[email protected]>
lmb
added a commit
to lmb/ebpf
that referenced
this pull request
Oct 16, 2025
The upstream efW removed the XDP_TEST program type from the repository. We rely on this type for our unit tests. Switch tests to the SAMPLE program type, which is a separate driver but also distributed as part of the efW runtime. On Windows, running a SAMPLE program requires providing a (possibly empty) context. To avoid having to change a lot of tests over and over we introduce a new mustRun helper. See: microsoft/ebpf-for-windows#4662 Signed-off-by: Lorenz Bauer <[email protected]>
lmb
added a commit
to cilium/ebpf
that referenced
this pull request
Oct 16, 2025
The upstream efW removed the XDP_TEST program type from the repository. We rely on this type for our unit tests. Switch tests to the SAMPLE program type, which is a separate driver but also distributed as part of the efW runtime. On Windows, running a SAMPLE program requires providing a (possibly empty) context. To avoid having to change a lot of tests over and over we introduce a new mustRun helper. See: microsoft/ebpf-for-windows#4662 Signed-off-by: Lorenz Bauer <[email protected]>
LakshK98
pushed a commit
to LakshK98/ebpf-for-windows
that referenced
this pull request
Nov 7, 2025
…4662) * Removed the XDP Test Extension * Fixed Failing Tests and scripts * Fixed the Fuzzer Build * Fixed documentation * Removed net_ebpf_ext_xdp_hooks.h and all XDP Unit tests * Fixed the Lib Fuzzer Harness * Fixed the Cilium Tests * ebpfVerifier Sync * Reverted files with only white space changes * CR feedback from Anurag * CR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the XDP Test hook from ebpf.
Work Item : #2974
All XDP tests like Xdp_test/encap_reflect xdp_test/decapsulate_reflect xdp_test/reflect are removed since they rely on the XDP_TEST hook.
Filed a work item in XDP to add support for _net_ebpf_xdp_adjust_head
microsoft/xdp-for-windows#891
Describe the purpose of and changes within this Pull Request.
Please reference an issue with a keyword such as Fixes #abc, Closes #xyz, etc., so the work can be tracked.
Testing
All the CI/CD tests are passing.
Do any existing tests cover this change? Are new tests needed?
This is covered by microsoft/xdp-for-windows#891
Documentation
Is there any documentation impact for this change?
Yes, The documentation is updated.
Installation
Is there any installer impact for this change?
No