Skip to content

Conversation

@shankarseal
Copy link
Collaborator

@shankarseal shankarseal commented Sep 13, 2025

Description

This PR makes the following changes:

  • Change the setup script to enable HVCI before installing duonic. Empirical evidence suggests that duonic installation was failing post enabling HVCI. No causality has been established. This is merely a workaround to make forward progress.
  • It sets fail-fast: false for the native only tests strategy matrix, so that failure in one flavor does not cancel the other.
  • It re-enables XDP tests to be run conditionally.
  • Refactor some functions so that setup/execution on local host, VM and remote VM share maximum code.
  • Removes some dead code from the scripts.
  • Additional logging.

Testing

This makes changes to the kernel driver test jobs.

Documentation

No documentation changes.

Installation

No installation changes.

@dthaler
Copy link
Collaborator

dthaler commented Sep 13, 2025

  • It removes the EnableHVCI flag from the driver native only tests. This change was made as there is empirical evidence that this flag introduced flakiness to the tests depending on the duonic tool.

Does this mean there's no way to test with HVCI enabled without introducing test failures? Is there an issue filed to track this?

@shankarseal
Copy link
Collaborator Author

shankarseal commented Sep 13, 2025

  • It removes the EnableHVCI flag from the driver native only tests. This change was made as there is empirical evidence that this flag introduced flakiness to the tests depending on the duonic tool.

Does this mean there's no way to test with HVCI enabled without introducing test failures? Is there an issue filed to track this?

Not necessarily. I am removing this to stabilize the pipeline ahead of the major release. We will work in parallel to sort this out.
[edit]. The order of commands to enable HVCI and installing duo NIC have been swapped. HVCI is still enabled.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes miscellaneous improvements to kernel driver test CICD jobs to reduce flakiness and improve reliability.

  • Removes the EnableHVCI flag from driver native only tests due to empirical evidence of flakiness
  • Adds fail-fast: false strategy to prevent one matrix flavor failure from canceling others
  • Re-enables conditional XDP tests execution

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/cicd.yml Removes EnableHVCI flag and adds fail-fast: false to driver native tests
.github/workflows/reusable-build.yml Adds continue-on-error to nuget cache step
scripts/vm_run_tests.psm1 Adds RunXdpTests parameter and conditional XDP test execution
scripts/execute_ebpf_cicd_tests.ps1 Passes through RunXdpTests parameter
scripts/common.psm1 Improves timeout error message clarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Alan-Jowett
Alan-Jowett previously approved these changes Sep 15, 2025
@shankarseal shankarseal force-pushed the fix_driver_test_jobs branch 2 times, most recently from 5324389 to 0f61d38 Compare September 19, 2025 21:40
matthewige
matthewige previously approved these changes Sep 19, 2025
@shankarseal shankarseal force-pushed the fix_driver_test_jobs branch 2 times, most recently from 6b52904 to 0fe1420 Compare September 24, 2025 00:33
@shankarseal shankarseal marked this pull request as ready for review September 24, 2025 02:23
LakshK98
LakshK98 previously approved these changes Sep 26, 2025
@shankarseal shankarseal force-pushed the fix_driver_test_jobs branch 4 times, most recently from cc02704 to 47b2d66 Compare October 2, 2025 22:18
@shankarseal shankarseal force-pushed the fix_driver_test_jobs branch from 47b2d66 to 8a45a0f Compare October 3, 2025 02:10
@shankarseal shankarseal added this pull request to the merge queue Oct 3, 2025
Merged via the queue into microsoft:main with commit 5736598 Oct 3, 2025
106 checks passed
@shankarseal shankarseal deleted the fix_driver_test_jobs branch October 3, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants