-
Notifications
You must be signed in to change notification settings - Fork 268
Miscellaneous changes to kernel driver test CICD jobs. #4641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this mean there's no way to test with HVCI enabled without introducing test failures? Is there an issue filed to track this? |
Not necessarily. I am removing this to stabilize the pipeline ahead of the major release. We will work in parallel to sort this out. |
d5705f0 to
2683880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes miscellaneous improvements to kernel driver test CICD jobs to reduce flakiness and improve reliability.
- Removes the
EnableHVCIflag from driver native only tests due to empirical evidence of flakiness - Adds
fail-fast: falsestrategy to prevent one matrix flavor failure from canceling others - Re-enables conditional XDP tests execution
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cicd.yml |
Removes EnableHVCI flag and adds fail-fast: false to driver native tests |
.github/workflows/reusable-build.yml |
Adds continue-on-error to nuget cache step |
scripts/vm_run_tests.psm1 |
Adds RunXdpTests parameter and conditional XDP test execution |
scripts/execute_ebpf_cicd_tests.ps1 |
Passes through RunXdpTests parameter |
scripts/common.psm1 |
Improves timeout error message clarity |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
804bf31 to
0405020
Compare
4d99fa7 to
dcb4f7d
Compare
5324389 to
0f61d38
Compare
6b52904 to
0fe1420
Compare
0fe1420 to
bce04f0
Compare
cc02704 to
47b2d66
Compare
47b2d66 to
8a45a0f
Compare
Description
This PR makes the following changes:
fail-fast: falsefor the native only tests strategy matrix, so that failure in one flavor does not cancel the other.Testing
This makes changes to the kernel driver test jobs.
Documentation
No documentation changes.
Installation
No installation changes.