Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simbatt: Fix broken registry read-back #1064

Merged
merged 1 commit into from
Jun 18, 2024
Merged

simbatt: Fix broken registry read-back #1064

merged 1 commit into from
Jun 18, 2024

Commits on May 3, 2024

  1. simbatt: Fix broken registry read-back 

    The GetSimBattStateFromRegistry function is currently using default settings if GetSimBattStateFromRegistry succeeds, whereas settings from registry are only applied if GetSimBattStateFromRegistry fails. This does not make sense to me.

Therefore proposing to remove the `!` negation from `if (!NT_SUCCESS(Status)) {` on the line after `Status = GetSimBattStateFromRegistry(Device, RegState);` so that default settings are loaded when registry read-back fails.
    @forderud
    Fredrik Orderud authored and forderud committed May 3, 2024
    Configuration menu
    Copy the full SHA
    54466da View commit details
    Browse the repository at this point in the history