simbatt: Fix broken registry read-back #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
force-pushed
the
GetSimBattStateFromRegistry-fix
branch
from
639da64
to
fa4567b
Compare
|
Gentle reminder. |
The GetSimBattStateFromRegistry function is currently using default settings if GetSimBattStateFromRegistry succeeds, whereas settings from registry are only applied if GetSimBattStateFromRegistry fails. This does not make sense to me.
Therefore proposing to remove the `!` negation from `if (!NT_SUCCESS(Status)) {` on the line after `Status = GetSimBattStateFromRegistry(Device, RegState);` so that default settings are loaded when registry read-back fails.
forderud
force-pushed
the
GetSimBattStateFromRegistry-fix
branch
from
fa4567b
to
54466da
Compare
|
@JakobL-MSFT Is it possible to get some kind of explanation for why this PR was closed instead of being considered for merging? Am I misunderstanding something, or don't you want to fix bugs in the sample code? |
|
I closed this PR unintentionally. I apologize. I am reopening the PR. |
tristanb-ntdev
approved these changes
May 22, 2024
|
@JakobL-MSFT @tristanb-ntdev Anything holding back merging of this bugfix? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetSimBattStateFromRegistryfunction is currently using default settings ifGetSimBattStateFromRegistrysucceeds, whereas settings from registry are only applied ifGetSimBattStateFromRegistryfails. This does not make sense to me.Therefore proposing to remove the
!negation fromif (!NT_SUCCESS(Status)) {on the line afterStatus = GetSimBattStateFromRegistry(Device, RegState);so that default settings are loaded when registry read-back fails.