Migrations: Update migrator to run faster by delegating document iteration to MongoDB #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom_each_document' into 2264-migrations-update-migrators-to-use-newly-implemented-adapter-methods-for-copying-and-deleting
|
brynnz22
approved these changes
Nov 13, 2024
eecavanna
deleted the
2264-migrations-update-migrators-to-use-newly-implemented-adapter-methods-for-copying-and-deleting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I did one new thing, plus I merged in two other branches that haven't yet been merged into
main(so, if this PR branch gets merged intomain, I'll close the PRs associated with those other two branches).The new thing I did in this branch is: I updated the
migrator_from_11_0_3_to_11_1_0_part_2so it would run faster. Specifically, I updated it to delegate an intensive task to MongoDB (which is optimized for that task), instead of doing it "manually" in Python.In order to accomplish that, I merged (into this branch) a couple branches, each of which introduced some necessary adapter method upon which the above migrator change depends. That's why this PR branch "includes" two other branches.
This PR supersedes #2262 and #2263.
I hope it works.