Add Manifest class
#2230
Add Manifest class
#2230
Conversation
|
|
@aclum, @SamuelPurvine, @corilo, @turbomam, @pdpiehowski - I could benefit from an early review and/or input on the |
|
the current values for ManifestCategoryEnum make sense to me. Tagging @mbthornton-lbl, if implemented nmdc_automation would have to check manifest_set to see if data objects should be combined together. |
There was a problem hiding this comment.
Thanks, this is good. Let's see what we can do together today in terms of refining the descriptions. I see you already have one comment about that. I'm going to suggest some more edits that emphasize minimal, realism-based descriptions.
I especially want to add comments about potential vulnerabilities in this modelling, which I think is mainly in the area of not enforcing some coupling with other schema elements, like any fractions manifest should correspond to data objects that were the output of one single fractionation process.
src/schema/basic_classes.yaml
Outdated
| in_manifest: | ||
| range: Manifest | ||
| multivalued: true | ||
| #TODO KRH: add description and structured_pattern constraints |
There was a problem hiding this comment.
What's the timeline for adding a description? Can I help in any way?
There was a problem hiding this comment.
one or more combinations of other DataObjects that can be analyzed together in the same context ?
|
@turbomam - Thanks for the assist with the descriptions and suggested comments, I've incorporated them all now and I think this is ready for merging! |
This PR
Manifestclass (inherits fromInformationclass) to model collections ofDataObjectsrecords for workflows.Manifestclass has slotmanifest_categorywith range ofManifestCategoryEnumin_manifestslot toDataObjectto connectDataObjects to aManifestor to multipleManifestssmanifest_settoDatabaseclassin_manifestslot,Manifestclass, andmanifest_setslotNo migration necessary, this only adds slots and classes and does not refactor existing classes or slots.
Addresses #766; should unblock microbiomedata/nmdc-server#1365