Skip to content

Commit

Permalink
talk to @eecavanna about schema length doc tests
Browse files Browse the repository at this point in the history
  • Loading branch information
turbomam committed Jul 17, 2024
1 parent d4b37a9 commit d2bfcf1
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions nmdc_schema/nmdc_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,6 @@ def get_nmdc_jsonschema_bytes(variant: Optional[SchemaVariantIdentifier] = None)
True
"""

# # removed
# >>> len(bytes_b) > len(bytes_a) # assumes that including structured patterns makes the file larger
# True

nmdc_json = get_nmdc_jsonschema_bytesIO(variant=variant)
return nmdc_json.getvalue()

Expand All @@ -143,10 +139,6 @@ def get_nmdc_jsonschema_string(variant: Optional[SchemaVariantIdentifier] = None
"""

# # removed
# >>> len(str_b) > len(str_a) # assumes that including structured patterns makes the file larger
# True

nmdc_json = get_nmdc_jsonschema_bytes(variant=variant)
return nmdc_json.decode("utf-8")

Expand Down

1 comment on commit d2bfcf1

@eecavanna
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @turbomam, in commit messages, I recommend telling the reader what would change if the commit were to be applied.

Example:

  • Remove doctests that compare lengths of schema files

Please sign in to comment.