Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berkeley: Update API GUI how-to guide related to /planned_processes endpoints #70

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brynnz22
Copy link
Contributor

This PR updates the API documentation to work with the new planned process endpoints. I was not able to test the endpoints while I worked because I think perlmutter is down today. I will test tomorrow, but I updated the docs assuming they work as expected.

This PR addresses issue: NMDC_documentation

I also updated the links to what they will be once Berkeley is merged in, so some of them technically won't work if you try them right now. Not sure if we want to wait to merge this PR until Berkeley is merged in. For example this link: https://microbiomedata.github.io/nmdc-schema/MetabolomicsAnalysis/ was updated from https://microbiomedata.github.io/nmdc-schema/MetabolomicsAnalysisActivity/

@brynnz22 brynnz22 changed the title planned process updates Updates to API docs based on planned process endpoints Sep 11, 2024
@aclum
Copy link
Contributor

aclum commented Sep 11, 2024

We should wait to merge this in until berkeley is merged in and we know the release of nmdc-runtime. Otherwise this looks good to me.

@brynnz22 brynnz22 self-assigned this Sep 12, 2024
@eecavanna
Copy link
Contributor

Looks good to me—thank you, @brynnz22!

I left one comment about the formatting of a URL.

I agree with @aclum about holding off on merging this until we have switched our production systems over to using the Berkeley schema.

@eecavanna eecavanna changed the title Updates to API docs based on planned process endpoints berkeley: Update API GUI how-to guide related to /planned_processes endpoints Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants